Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noinline directives from new commit phase #20241

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Remove noinline directives from new commit phase #20241

merged 1 commit into from
Nov 12, 2020

Commits on Nov 12, 2020

  1. Remove noinline directives from new commit phase 

    My theory for too much inlining contributing to overall stack size is
likely flawed, because Closure reuses variables within a function to
optimize registers.

Even if my theory were correct, the impact would be minimal anyway
because the recursive implementation of the commit phase traversals is
behind a disabled feature flag.

Going to revert this. We can maybe test the impact once we land the
commit phase changes. In the meantime, I'd prefer to eliminate this
delta from the new fork.
    @acdlite
    acdlite committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    cd7c421 View commit details
    Browse the repository at this point in the history