Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork ReactFiberLane #20371

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Fork ReactFiberLane #20371

merged 1 commit into from
Dec 4, 2020

Commits on Dec 3, 2020

  1. Fork ReactFiberLane 

    This wasn't forked previously because Lane and associated types are
opaque, and they leak into non-reconciler packages. So forking the type
would also require forking all those other packages.

But I really want to use the reconciler fork infra for lanes changes.
So I made them no longer opaque.

Another possible solution would be to add separate `new` and `old`
fields to the Fiber type, like I did when migrating from expiration
times. But that seems so excessive. This seems fine.

But we should still treat them like they're opaque and only do lanes
manipulation in the ReactFiberLane module. At least until the model
stabilizes more. We'll just need to enforce this with discipline
instead of with the type system.
    @acdlite
    acdlite committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    4ab5407 View commit details
    Browse the repository at this point in the history