Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-flight): add support to typescript .client files on webpac… #20547

Closed
wants to merge 1 commit into from

Conversation

sibelius
Copy link

@sibelius sibelius commented Jan 5, 2021

…k flight plugin

Summary

Typescript files should also be inside react-client-manifest.json to make server components works well in a typescript codebase

Test Plan

I'm testing all these changes on my POC repo here https://github.com/sibelius/react-server-components-boilerplate

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5643c33:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jan 5, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 5643c33

@sizebot
Copy link

sizebot commented Jan 5, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 5643c33

@stale
Copy link

stale bot commented Jun 11, 2021

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jun 11, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants