New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V17.0.1 lifecycle tests with noop #20563
V17.0.1 lifecycle tests with noop #20563
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e9ccb7:
|
…f these tests now pass in DEV, though some still seem to be designed not to; will investigate further soon.
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Rough draft of some changes to make the class component lifecycle tests use the noop renderer instead of React DOM. Still some changes needed to clean this up.
I've been running the tests with:
yarn test --env production -r www-modern -v packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js
This is based off of the 17.0.1 tag, so it's obviously going to need some more adjustment if we want to contribute it to upstream
master
.