Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Combine reducers #20591

Closed
wants to merge 3 commits into from
Closed

Conversation

mstill3
Copy link

@mstill3 mstill3 commented Jan 14, 2021

Summary

Just an extra method to combine reducers built into the react context hook api, as Redux has

Test Plan

I wrote a test to show it functioning the way I anticipated

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0602ce5:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jan 14, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 0602ce5

@sizebot
Copy link

sizebot commented Jan 14, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 0602ce5

@markerikson
Copy link
Contributor

This really does not need to be added to React, at all. It can stay in userland.

@rickhanlonii
Copy link
Member

Hey @mstill3, thanks for the suggestion and tests. Let's leave this in user-land though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants