Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ToStringValue.js #20633

Closed
wants to merge 7 commits into from
Closed

Conversation

Ubachukwu-Ibeh
Copy link

Added 'bigint' to getToStringValue case

Summary

Test Plan

Added 'bigint' to getToStringValue case
@facebook-github-bot
Copy link

Hi @redbossrabbit!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc97b89:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jan 20, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against dc97b89

@sizebot
Copy link

sizebot commented Jan 20, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against dc97b89

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Added BigInt type to Opaque ToStringValue type
Fixed bigint test case type
@@ -28,6 +29,7 @@ export function getToStringValue(value: mixed): ToStringValue {
case 'number':
case 'object':
case 'string':
case 'bigint':
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit-pick: Both the opaque type and case statement are ordered A-Z. Thus, should be move bigint into its natural place? e.g.

    case 'bigint':
    case 'boolean':
    case 'number':
    case 'object':
    case 'string':

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright. Will do.

Repositioned bigint type to preserve chronological order of arrangements in getToStringValue and opaque ToStringValue types.
@rickhanlonii
Copy link
Member

Could you add a test for this?

@Ubachukwu-Ibeh
Copy link
Author

Will do.

@stale
Copy link

stale bot commented Jun 11, 2021

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jun 11, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants