New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ToStringValue.js #20633
Update ToStringValue.js #20633
Conversation
Added 'bigint' to getToStringValue case
Hi @redbossrabbit! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc97b89:
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Added BigInt type to Opaque ToStringValue type
Fixed bigint test case type
commig
@@ -28,6 +29,7 @@ export function getToStringValue(value: mixed): ToStringValue { | |||
case 'number': | |||
case 'object': | |||
case 'string': | |||
case 'bigint': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit-pick: Both the opaque type and case statement are ordered A-Z. Thus, should be move bigint into its natural place? e.g.
case 'bigint':
case 'boolean':
case 'number':
case 'object':
case 'string':
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Will do.
Repositioned bigint type to preserve chronological order of arrangements in getToStringValue and opaque ToStringValue types.
Could you add a test for this? |
Will do. |
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Added 'bigint' to getToStringValue case
Summary
Test Plan