DEV warning for "strict effects mode" (Facebook only) #20694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 97ca787:
|
bvaughn
force-pushed
the
strict-effects-mode-dev-console-warning
branch
from
a18097f
to
cc293cf
Compare
Details of bundled changes.Comparing: bb1b795...97ca787 react-art
react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
Details of bundled changes.Comparing: bb1b795...97ca787 react-art
react-dom
Size changes (stable) |
bvaughn
force-pushed
the
strict-effects-mode-dev-console-warning
branch
from
cc293cf
to
edf51d1
Compare
|
Oops I need to tweak this to use two flags: one to enable it for FB only and one to allow developers to opt-out. The reason here is that I can't set a GK to 100% of employees. Will update momentarily. |
|
CI test |
This commit adds a temporary DEV mode warning that explains strict effects mode. It's intended for Facebook builds only, because the warning includes Facebook specific instructions for how to disable it (using a GK blocklist). If we decide to add a similar warning for OSS we'll need to revisit both the wording and the opt-out mechansim. This new behavior is controlled by two separate flags. This lets us (a) can enable it for 100% of Facebook engineers¹² and (b) provide a simple opt-out mechanism for engineers who know about the mode and no longer want to see the warning. ¹ This warning will not be logged for legacy applications that aren't in strict effects mode. ² GKs within Facebook can't be enabled for 100% of a population.
bvaughn
force-pushed
the
strict-effects-mode-dev-console-warning
branch
from
741626e
to
97ca787
Compare
|
Opened an internal Diff with an alternate way of adding this warning (via a wrapper around the create-root entry points). |
|
Closing in favor of the Facebook wrapper approach mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a temporary DEV mode warning that explains strict effects mode. It's intended for Facebook builds only, because the warning includes Facebook specific instructions for how to disable it (using a GK blocklist). If we decide to add a similar warning for OSS we'll need to revisit both the wording and the opt-out mechansim.
Note that this new warning is controlled by two new feature flags so that (1) we can enable it for 100% of Facebook engineers¹² only (no OSS) and (2) provide a simple opt-out mechanism for engineers who know about the mode and no longer want to see the warning.
¹ This warning will not be logged for legacy applications that aren't in strict effects mode.
² GKs within Facebook can't be enabled for 100% of a population.
enableStrictEffectsModeDevWarningForFacebookOnlyis enabled statically at build time and is used to enable the warning within Facebook builds only.bypassStrictEffectsModeDevWarningForFacebookOnlyis a dynamic flag and provides an opt-out mechanism (allowlisting yourself to a GK).Both flags are gated behind an extra
__DEV__check so they should not impact production build size.