Some release script fixes #20718
Merged
Some release script fixes #20718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the otp times out, we should not retry the packages that were already successfully published. We should pick up where we left off.
The "print follow up instructions" step crashes if build-info.json is not found. The new build workflow doesn't include those yet (might not need to) and since the instructions that depend on it only affect semver (latest) releases, I've moved the code to that branch. Will follow up with a proper fix, either by adding back a build-info.json file or removing that dependency and reading the commit some other way.
facebook-github-bot
added
CLA Signed
React Core Team
acdlite
commented
Feb 2, 2021
| const run = async ({cwd, dry, packages, tags}, otp) => { | ||
| clear(); | ||
| const run = async ({cwd, dry, tags}, packageName, otp) => { | ||
| const packagePath = join(cwd, 'build/node_modules', packageName); |
There was a problem hiding this comment.
Only real change here is I hoisted the for loop into the outer caller
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 74ac980:
|
rickhanlonii
approved these changes
Feb 2, 2021
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Retry loop should not start over from beginning When the otp times out, we should not retry the packages that were already successfully published. We should pick up where we left off. * Don't crash if build-info.json doesn't exist The "print follow up instructions" step crashes if build-info.json is not found. The new build workflow doesn't include those yet (might not need to) and since the instructions that depend on it only affect semver (latest) releases, I've moved the code to that branch. Will follow up with a proper fix, either by adding back a build-info.json file or removing that dependency and reading the commit some other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few rough edges left over from my recent changes to the build + release pipeline.
Found and tested by publishing new "next" (0.0.0-dc27b5aaa) and "experimental" (0.0.0-experimental-dc27b5aaa) pre-releases.