Fallback if GitHub status is stuck as "pending" #20729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub's status API is super flaky. Sometimes it reports a job as "pending" even after it completes in CircleCI. If it's still pending when we time out, return the build ID anyway. TODO: The location of the retry loop is a bit weird. We should probably combine this function with the one that downloads the artifacts, and wrap the retry loop around the whole thing.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 20aa1f5:
|
acdlite
force-pushed
the
fallback-if-github-status-api-is-stuck
branch
2 times, most recently
from
398cec4
to
20aa1f5
Compare
Size changesComparing: 3be750e...20aa1f5 Stable channelNo significant bundle size changes to report. Experimental channelNo significant bundle size changes to report. |
|
Going to merge this to unbreak #20728 |
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
GitHub's status API is super flaky. Sometimes it reports a job as "pending" even after it completes in CircleCI. If it's still pending when we time out, return the build ID anyway. TODO: The location of the retry loop is a bit weird. We should probably combine this function with the one that downloads the artifacts, and wrap the retry loop around the whole thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's status API is super flaky. Sometimes it reports a job as "pending" even after it completes in CircleCI. If it's still pending when we time out, return the build ID anyway.
(The location of the retry loop is a bit weird. We should probably combine get-build-for-id with download-build-artifacts, and wrap the retry loop around the whole thing.)