Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ReactFiberLane.new.js #21353

Closed
wants to merge 1 commit into from
Closed

Conversation

eltociear
Copy link
Contributor

Summary

Fixed typo.

continous -> continuous

Test Plan

continous -> continuous
@sizebot
Copy link

sizebot commented Apr 26, 2021

Comparing: 4874042...4532edc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.76 kB 122.76 kB = 39.42 kB 39.42 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.34 kB 129.34 kB = 41.51 kB 41.51 kB
facebook-www/ReactDOM-prod.classic.js = 412.52 kB 412.52 kB = 76.35 kB 76.35 kB
facebook-www/ReactDOM-prod.modern.js = 400.55 kB 400.55 kB = 74.45 kB 74.45 kB
facebook-www/ReactDOMForked-prod.classic.js = 412.52 kB 412.52 kB = 76.35 kB 76.35 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4532edc

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type fix is fine here, but can't land this change without also changing packages/react-reconciler/src/ReactFiberLane.old.js. These two files must match.

@bvaughn bvaughn closed this Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants