Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve the true entry point during tests #21505

Merged
merged 6 commits into from Jun 3, 2021
Merged

Resolve the true entry point during tests #21505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a808673
Resolve the entry point for tests the same way builds do
sebmarkbage May 13, 2021
955b294
Gate test selectors on www
sebmarkbage Jun 1, 2021
f5bd334
Gate createEventHandle / useFocus on www
sebmarkbage Jun 1, 2021
0e204dd
Temporarily disable www-modern entry point
sebmarkbage Jun 2, 2021
8e48c55
Remove enableCache override that's no longer correct
sebmarkbage Jun 2, 2021
9889b1e
Open gates for www
sebmarkbage Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.js
View file
Open in desktop
Expand Up @@ -286,7 +286,7 @@ describe('ReactDOMFiberAsync', () => {
expect(ops).toEqual(['BC', 'ABCD']);
});

// @gate experimental
// @gate experimental || www
it('flushControlled flushes updates before yielding to browser', () => {
let inst;
class Counter extends React.Component {
Expand Down Expand Up @@ -326,7 +326,7 @@ describe('ReactDOMFiberAsync', () => {
]);
});

// @gate experimental
// @gate experimental || www
it('flushControlled does not flush until end of outermost batchedUpdates', () => {
let inst;
class Counter extends React.Component {
Expand Down Expand Up @@ -357,7 +357,7 @@ describe('ReactDOMFiberAsync', () => {
]);
});

// @gate experimental
// @gate experimental || www
it('flushControlled returns nothing', () => {
// In the future, we may want to return a thenable "work" object.
let inst;
Expand Down
12 changes: 6 additions & 6 deletions packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js
View file
Open in desktop
Expand Up @@ -571,7 +571,7 @@ describe('ReactDOMServerPartialHydration', () => {
expect(span.className).toBe('hi');
});

// @gate experimental
// @gate experimental || www
it('blocks updates to hydrate the content first if props changed at idle priority', async () => {
let suspend = false;
let resolve;
Expand Down Expand Up @@ -1498,7 +1498,7 @@ describe('ReactDOMServerPartialHydration', () => {
expect(container.textContent).toBe('ALoading B');
});

// @gate experimental
// @gate experimental || www
it('clears server boundaries when SuspenseList runs out of time hydrating', async () => {
let suspend = false;
let resolve;
Expand Down Expand Up @@ -1912,7 +1912,7 @@ describe('ReactDOMServerPartialHydration', () => {
document.body.removeChild(container);
});

// @gate experimental
// @gate www
it('does not invoke an event on a hydrated event handle until it commits', async () => {
const setClick = ReactDOM.unstable_createEventHandle('click');
let suspend = false;
Expand Down Expand Up @@ -2077,7 +2077,7 @@ describe('ReactDOMServerPartialHydration', () => {
document.body.removeChild(container);
});

// @gate experimental
// @gate www
it('invokes discrete events on nested suspense boundaries in a root (createEventHandle)', async () => {
let suspend = false;
let isServerRendering = true;
Expand Down Expand Up @@ -2617,7 +2617,7 @@ describe('ReactDOMServerPartialHydration', () => {
expect(span.innerHTML).toBe('Hidden child');
});

// @gate experimental
// @gate experimental || www
it('renders a hidden LegacyHidden component inside a Suspense boundary', async () => {
const ref = React.createRef();

Expand Down Expand Up @@ -2646,7 +2646,7 @@ describe('ReactDOMServerPartialHydration', () => {
expect(span.innerHTML).toBe('Hidden child');
});

// @gate experimental
// @gate experimental || www
it('renders a visible LegacyHidden component', async () => {
const ref = React.createRef();

Expand Down
10 changes: 5 additions & 5 deletions packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js
View file
Open in desktop
Expand Up @@ -369,7 +369,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
document.body.removeChild(container);
});

// @gate experimental
// @gate www
it('hydrates the target boundary synchronously during a click (createEventHandle)', async () => {
const setClick = ReactDOM.unstable_createEventHandle('click');
let isServerRendering = true;
Expand Down Expand Up @@ -438,7 +438,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
document.body.removeChild(container);
});

// @gate experimental
// @gate www
it('hydrates at higher pri if sync did not work first time (createEventHandle)', async () => {
let suspend = false;
let isServerRendering = true;
Expand Down Expand Up @@ -526,7 +526,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
document.body.removeChild(container);
});

// @gate experimental
// @gate www
it('hydrates at higher pri for secondary discrete events (createEventHandle)', async () => {
const setClick = ReactDOM.unstable_createEventHandle('click');
let suspend = false;
Expand Down Expand Up @@ -812,7 +812,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
document.body.removeChild(container);
});

// @gate experimental
// @gate experimental || www
it('hydrates the last explicitly hydrated target at higher priority', async () => {
function Child({text}) {
Scheduler.unstable_yieldValue(text);
Expand Down Expand Up @@ -861,7 +861,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
expect(Scheduler).toFlushAndYield(['App', 'C', 'B', 'A']);
});

// @gate experimental
// @gate experimental || www
it('hydrates before an update even if hydration moves away from it', async () => {
function Child({text}) {
Scheduler.unstable_yieldValue(text);
Expand Down