Upgrade jest to v29 #21575

eps1lon · 2021-05-27T10:02:24Z

Waiting for release of jestjs/jest#13328

Summary

unhandled errors from JSDOM are now proper errors instead of strings
no more abortSignal.reason = ... hack in JSDOM environments
JSDOM environment by default now

Test Plan

CI green

sizebot · 2021-05-27T10:06:57Z

Comparing: 9c3de25...8d0a41d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	135.47 kB	135.47 kB	=	43.41 kB	43.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	147.73 kB	147.73 kB	=	47.17 kB	47.17 kB
facebook-www/ReactDOM-prod.classic.js	=	491.70 kB	491.70 kB	=	87.49 kB	87.49 kB
facebook-www/ReactDOM-prod.modern.js	=	477.00 kB	477.00 kB	=	85.24 kB	85.24 kB
facebook-www/ReactDOMForked-prod.classic.js	=	491.70 kB	491.70 kB	=	87.49 kB	87.49 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/jest-react/cjs/jest-react.production.min.js	+1.07%	2.42 kB	2.45 kB	+1.11%	1.17 kB	1.18 kB
oss-stable-semver/jest-react/cjs/jest-react.production.min.js	+1.07%	2.42 kB	2.45 kB	+1.11%	1.17 kB	1.18 kB
oss-stable/jest-react/cjs/jest-react.production.min.js	+1.07%	2.42 kB	2.45 kB	+1.11%	1.17 kB	1.18 kB
oss-experimental/jest-react/cjs/jest-react.development.js	+0.25%	10.61 kB	10.64 kB	+0.40%	3.75 kB	3.76 kB
oss-stable-semver/jest-react/cjs/jest-react.development.js	+0.25%	10.61 kB	10.64 kB	+0.40%	3.75 kB	3.76 kB
oss-stable/jest-react/cjs/jest-react.development.js	+0.25%	10.61 kB	10.64 kB	+0.40%	3.75 kB	3.76 kB

Generated by 🚫 dangerJS against 8d0a41d

eps1lon · 2021-11-23T20:13:06Z

packages/react-dom/src/__tests__/ReactDOMEventPropagation-test.js

@@ -7,7 +7,7 @@

 'use strict';

-describe('ReactDOMEventListener', () => {
+describe('ReactDOMEventPropagation', () => {


Drive-by change. The suite name now matches the file name.

eps1lon · 2021-11-23T20:19:12Z

packages/react-dom/src/__tests__/ReactDOMEventPropagation-test.js

-    React = require('react');
    jest.isolateModules(() => {
-      OuterReactDOM = require('react-dom');
+      InnerReactDOM = require('react-dom');
    });
    jest.isolateModules(() => {
-      InnerReactDOM = require('react-dom');
+      React = require('react');
+      OuterReactDOM = require('react-dom');


Fixes https://app.circleci.com/pipelines/github/facebook/react/21294/workflows/b23b2fbb-9d67-447c-b395-21591b60ebf1/jobs/411166.

Probably required due to jestjs/jest#10963. Though it's unclear why this test passed without this change using scripts/jest/config.source-www.js but failed using scripts/jest/config.build.js.

@SimenB Any idea if this is intended?

Sounds odd that changing config impacts module loading. My only guess is

react/scripts/jest/config.build.js

Lines 38 to 46 in c1220eb

// Map packages to bundles

packages.forEach(name => {

// Root entry point

moduleNameMapper[`^${name}$`] = `<rootDir>/build/${NODE_MODULES_DIR}/${name}`;

// Named entry points

moduleNameMapper[

`^${name}\/([^\/]+)$`

] = `<rootDir>/build/${NODE_MODULES_DIR}/${name}/$1`;

});

makes it resolve to differing modules somehow?

The modules were all coming from the mapped paths.
To be clear: It makes sense that the used React needs to be the same one that's used by OuterReactDOM and therefore needs to be in the same isolatedModules callback. What's odd is, that this isn't the case with scripts/jest/config.source-www.js.

So ideally we'd have two isolated copies of react-dom that somehow share the same react copy. This no longer seems possible with Jest 27

Seems you've worked around this, but a solution might be a new API which lets you selectively evict specific modules from the cache? jest.resetModule('react-dom') or something?

I haven't thought about this for a while but if I remember correctly, I came to the conclusiong that the old code should never have worked to begin with. Not sure if it's worth revisiting since this testing pattern is very specific.

That sounds very reasonable 👍 It does sound like a weird edge case, but happy to revisit it if proves to actually guard against some regression 🙂

eps1lon · 2022-03-08T08:51:50Z

Some CI shards are failing with out-of-memory errors. Going to take a while identifying the memory leaks.

gaearon · 2022-04-03T18:38:24Z

Anything blocking this?

eps1lon · 2022-04-03T19:00:03Z

Anything blocking this?

I noticed an issue when running updateSnapshot on useId tests (running --updateSnashot without e44ea79). So I'd like to check if this is already broken on main or new with Jest 27.

eps1lon · 2022-04-04T17:21:34Z

@gaearon jestjs/jest#11561 is blocking this update. Jest without --updateSnapshot would be quite boring.

SimenB · 2022-08-19T14:41:49Z

Easiest to unblock is probably to float a patch (e.g. patch-package) just removing https://www.runpkg.com/?jest-snapshot@27.5.1/build/InlineSnapshots.js#222. The fix for the above issue will be in Jest 29, but going from 26 straight to 29 sounds like a lot 😀

At least as long as babel config is available to babel's own way of looking it up. If not, straight to 29 might be needed

TODO: investigate why we can't update snapshots

eps1lon · 2022-10-02T10:05:30Z

packages/react-dom/src/__tests__/ReactDOMFloat-test.js

@@ -470,7 +484,6 @@ describe('ReactDOMFloat', () => {
          <head />
          <body>
            foo
-            <link rel="preload" as="style" href="foo" />


According to the test, its actions should be run on the server. But as far as I can tell, there's only a client dispatcher (ReactDOMClientDispatcher).

@gnoff Do you have a e2e test for this scenario so that we can verify where the test environment might not be setup properly?

Jest has become a lot stricter with mixing environments and these sort of tests break due to strict environment separation. IMO this is ok behavior from Jest since it makes it more obvious where particular code is running.

SimenB · 2022-10-19T06:38:51Z

React Native and Metro have both upgraded to v29. Would be great if React could as well! 😀

ymqy · 2023-01-30T23:55:57Z

@eps1lon Why hasn't this pr been merged yet? I submitted a pr and all the ci tests have passed. It includes more optimization upgrades. #26041

eps1lon · 2023-01-31T03:31:28Z

Because it has merge conflicts and was not reviewed in its latest state

eps1lon · 2023-02-09T17:02:17Z

Landed in #26088

facebook-github-bot added the CLA Signed label May 27, 2021

eps1lon force-pushed the chore/jest-27 branch from 8365b18 to d7385e3 Compare June 30, 2021 12:13

eps1lon changed the base branch from master to main June 30, 2021 12:14

crypt096 approved these changes Jul 15, 2021

View reviewed changes

eps1lon force-pushed the chore/jest-27 branch from d7385e3 to 1f3a7ca Compare November 23, 2021 19:01

eps1lon commented Nov 23, 2021

View reviewed changes

gaearon approved these changes Nov 23, 2021

View reviewed changes

eps1lon force-pushed the chore/jest-27 branch from b358da4 to 0e0bb1d Compare January 15, 2022 16:30

eps1lon marked this pull request as draft March 7, 2022 19:48

eps1lon force-pushed the chore/jest-27 branch 3 times, most recently from 45bac8e to 0166dd3 Compare March 8, 2022 08:34

eps1lon force-pushed the chore/jest-27 branch from 0166dd3 to 1503363 Compare March 19, 2022 11:17

eps1lon changed the title ~~Update jest to v27~~ Upgrade jest to v27 Mar 19, 2022

eps1lon force-pushed the chore/jest-27 branch 2 times, most recently from a86d1ea to e44ea79 Compare March 20, 2022 12:41

eps1lon force-pushed the chore/jest-27 branch from e44ea79 to fcf66db Compare April 4, 2022 17:07

eps1lon mentioned this pull request Apr 4, 2022

Inline Snapshots fail to update if test uses JSX jestjs/jest#11561

Closed

eps1lon mentioned this pull request May 23, 2022

Add end-of-frame scheduling for default events #24594

Closed

13 tasks

eps1lon changed the title ~~Upgrade jest to v27~~ Upgrade jest to v28 Sep 10, 2022

This comment was marked as resolved.

Sign in to view

eps1lon force-pushed the chore/jest-27 branch from ef13198 to 0e3a9e4 Compare September 10, 2022 13:28

This comment was marked as resolved.

Sign in to view

eps1lon added 16 commits October 2, 2022 10:41

Fix pretty-format breakage

1ee8e96

Fix breakage regarding (set|clear)Immediate

125956e

Update jest

a390ca0

Pull in upstream fix of createCacheKeyFunction

5505b1f

ensure react-dom sets the proper dispatcher in the global react

a4a0276

Resolve breaking changes due to changed export namespace of jest-diff

a2a4f47

Use actual Jest environment to mix environments

bc7a094

Fix useId tests

211024e

TODO: investigate why we can't update snapshots

Upgrade jest to 27.5.1

98118ee

BROKEN Upgrade to Jest 28

229921e

Install Jest 29

e580909

Greeeen!

6ec6eeb

Fix flow

67f776f

Upgrade to Jest 29.1.1

84286a8

Fix experimental tests

0a7b29c

Fix production tests

d8f4c8a

eps1lon force-pushed the chore/jest-27 branch from a538460 to a14bb54 Compare October 2, 2022 09:26

We'll get there

6bf603b

eps1lon force-pushed the chore/jest-27 branch from a14bb54 to 56c2c3d Compare October 2, 2022 09:58

eps1lon commented Oct 2, 2022

View reviewed changes

Update float test with server assertions

8d0a41d

eps1lon force-pushed the chore/jest-27 branch from 56c2c3d to 8d0a41d Compare October 2, 2022 12:29

eps1lon mentioned this pull request Jan 25, 2023

Upgrading Jest to v29 and optimizing default configuration #26041

Closed

ymqy mentioned this pull request Feb 1, 2023

Update to Jest 29 #26088

Merged

eps1lon closed this Feb 9, 2023

eps1lon deleted the chore/jest-27 branch February 9, 2023 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade jest to v29 #21575

Upgrade jest to v29 #21575

eps1lon commented May 27, 2021 •

edited

sizebot commented May 27, 2021 •

edited

eps1lon Nov 23, 2021

eps1lon Nov 23, 2021

SimenB Nov 24, 2021

eps1lon Nov 24, 2021

SimenB Sep 28, 2022

eps1lon Sep 28, 2022

SimenB Sep 28, 2022

eps1lon commented Mar 8, 2022

gaearon commented Apr 3, 2022

eps1lon commented Apr 3, 2022

eps1lon commented Apr 4, 2022

SimenB commented Aug 19, 2022 •

edited

This comment was marked as resolved.

This comment was marked as resolved.

eps1lon Oct 2, 2022

SimenB commented Oct 19, 2022

ymqy commented Jan 30, 2023

eps1lon commented Jan 31, 2023

eps1lon commented Feb 9, 2023

	// Map packages to bundles
	packages.forEach(name => {
	// Root entry point
	moduleNameMapper[`^${name}$`] = `<rootDir>/build/${NODE_MODULES_DIR}/${name}`;
	// Named entry points
	moduleNameMapper[
	`^${name}\/([^\/]+)$`
	] = `<rootDir>/build/${NODE_MODULES_DIR}/${name}/$1`;
	});

Upgrade jest to v29 #21575

Upgrade jest to v29 #21575

Conversation

eps1lon commented May 27, 2021 • edited

Summary

Test Plan

sizebot commented May 27, 2021 • edited

Critical size changes

Significant size changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eps1lon commented Mar 8, 2022

gaearon commented Apr 3, 2022

eps1lon commented Apr 3, 2022

eps1lon commented Apr 4, 2022

SimenB commented Aug 19, 2022 • edited

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

SimenB commented Oct 19, 2022

ymqy commented Jan 30, 2023

eps1lon commented Jan 31, 2023

eps1lon commented Feb 9, 2023

eps1lon commented May 27, 2021 •

edited

sizebot commented May 27, 2021 •

edited

SimenB commented Aug 19, 2022 •

edited