Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppRoutes moved into separate file as TODO item #21585

Closed
wants to merge 4 commits into from
Closed

AppRoutes moved into separate file as TODO item #21585

wants to merge 4 commits into from

Conversation

berkelmas
Copy link

Summary

In fixtures/blocks, there is a TODO item as moving AppRoutes into separate file. I think it is because server/App.js should be decoupled from pages and we should have a separate file for having all screens with their route definitions as a better architecture.

Test Plan

The blocks app should run without any error to make sure that all imports in both newly created file(AppRoutes.js) and main file(App.js) are correct.

@sizebot
Copy link

sizebot commented May 30, 2021

Comparing: 28625c6...853103e

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.00 kB 126.00 kB = 40.41 kB 40.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.82 kB 128.82 kB = 41.35 kB 41.35 kB
facebook-www/ReactDOM-prod.classic.js = 406.15 kB 406.15 kB = 75.12 kB 75.12 kB
facebook-www/ReactDOM-prod.modern.js = 394.52 kB 394.52 kB = 73.31 kB 73.30 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.15 kB 406.15 kB = 75.13 kB 75.13 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 853103e

@berkelmas
Copy link
Author

I cannot understand why sync_reconciler_forks step is failing though. Could anyone please help me ?

@berkelmas berkelmas closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants