Add concurrentRoot property to ReactNativeTypes #21648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammy-SC
changed the title
sammy-SC
changed the title
|
Comparing: 1a3f1af...18737a0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
bvaughn
reviewed
Jun 10, 2021
| @@ -182,6 +182,7 @@ export type ReactNativeType = { | |||
| element: Element<ElementType>, | |||
| containerTag: number, | |||
| callback: ?() => void, | |||
| concurrentRoot: ?boolean, | |||
There was a problem hiding this comment.
This param isn't on the Paper render, only Fabric.
There was a problem hiding this comment.
Got it, I added it because Flow was still complaining but I found why.
Fabric is using Paper's type (https://github.com/facebook/react/blob/master/scripts/rollup/shims/react-native/ReactFabric.js#L16)
I changed it in 3744c12
I hope it was fine to remove the todo (cc @sebmarkbage).
sammy-SC
force-pushed
the
add-concurrent-root-parameter
branch
from
3744c12
to
18737a0
Compare
rickhanlonii
approved these changes
Jun 10, 2021
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jun 11, 2021
Summary: This sync includes the following changes: - **[c96b78e0e](facebook/react@c96b78e0e )**: Add concurrentRoot property to ReactNativeTypes ([#21648](facebook/react#21648)) //<Samuel Susla>// - **[1a3f1afbd](facebook/react@1a3f1afbd )**: [React Native] Fabric get current event priority ([#21553](facebook/react#21553)) //<Samuel Susla>// - **[48a11a3ef](facebook/react@48a11a3ef )**: Update next React version ([#21647](facebook/react#21647)) //<Andrew Clark>// - **[5aa0c5671](facebook/react@5aa0c5671 )**: Fix Issue with Undefined Lazy Imports By Refactoring Lazy Initialization Order ([#21642](facebook/react#21642)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions 0eea577...c96b78e jest_e2e[run_all_tests] Reviewed By: bvaughn Differential Revision: D29029542 fbshipit-source-id: 9f2e19b4714b5697b5b846f2db8eb28c25420932
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
* Add concurrentRoot property to ReactNativeTypes * Add concurrentRoot to ReactNativeType * Use ReactFabricType instead of ReactNativeType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added concurrent root flag to render function for Fabric in #21552.
I forgot to add it to ReactNativeTypes for its Flow type. This PR fixes that.
Test Plan
Make sure the function signature from
ReactNativeTypes.jsaligns with function inReactFabric.js.