Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log and show error overlay for commit phase errors #21723

Merged
merged 3 commits into from Jun 24, 2021
Merged

Log and show error overlay for commit phase errors #21723

merged 3 commits into from Jun 24, 2021

Commits on Jun 24, 2021

  1. Enable skipped tests from facebook#21723

    @gaearon
    gaearon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    9bdbbb1 View commit details
    Browse the repository at this point in the history

  2. Report uncaught errors in DEV

    @gaearon
    gaearon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    45884e9 View commit details
    Browse the repository at this point in the history

  3. Clear caught error 

    This is not necessary (as proven by tests) because next invokeGuardedCallback clears it anyway. But I'll keep it for consistency with other calls.
    @gaearon
    gaearon committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    02e22a7 View commit details
    Browse the repository at this point in the history