refactor(react-jsx): solve some code smell #21826
Conversation
|
It seems that Circleci has a problem, I am trying to restart Check |
|
Comparing: 241485a...3dd171a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
1. reduce `getComponentNameFromType` call 2. reduce `let` use
liuarui
force-pushed
the
refactor/react-jsx
branch
from
1a5c2f8
to
3dd171a
Compare
|
It seems that Circleci has a problem🤣 |
| let didWarnAboutStringRefs; | ||
| let specialPropKeyWarningShown, | ||
| specialPropRefWarningShown, | ||
| didWarnAboutStringRefs; |
There was a problem hiding this comment.
This change seems purely subjective. Some may prefer one way, others another. We usually don't merge subjective changes to the code. 😄
There was a problem hiding this comment.
get, thank you for your reply.
I am sorry to bother your time, my intention just wants the React code better.🤣
There was a problem hiding this comment.
hahaha, But another change I hope that can make changes in subsequent, because it does make a function call without necessary.
|
i will close |
Summary
When I learn the react source, I found some small errors that don't affect code execution.
Refactor some
react/jsxReactJSXElement.jscodeTest Plan
just refactor, and I have passed the local test