-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames master to main in fixtures/flight webpack config file #21998
Conversation
Hi @junaidbinfarooq! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I'm not sure why the "sync_reconciler_forks" CI task is failing but I don't think we can land this PR while it is (or it would break the main branch). |
Comparing: 4df10c5...23d67be Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
Right. I saw the text, but it doesn't make sense given the file (and the change) that was made. |
Exactly, that is what I was thinking too. |
Running the suggested command applies changes to various files in the |
Is there any way to fix the said build issue? |
Sorry. I don't know or I would have suggested a fix. 😦 |
Perhaps, creating a branch directly and subsequently a new pr on the said repo without a fork can prevent this issue? |
This is definitely a problem with our Edit: #22151 (comment) |
Now that #22156 has landed, if you rebase on HEAD of |
944e501
to
23d67be
Compare
I guess it's probably fine to sync this, since |
Summary
Updates the reference to the main branch in the webpack config file of fixtures/flight package
Test Plan
No tests are required.