[DevTools] Only call SourceMapConsumer.originalPositionFor once #22181
+66
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
approved these changes
Aug 26, 2021
|
I just realized that I'm refactoring this code (#22198) because of the network cache issue, and we're going to clash. I made sure to rebase before starting, but I hadn't realized that this change never got merged. Now I'm pretty far into the refactor. Can we hold off on landing this for now? |
jstejada
force-pushed
the
original-position-for
branch
2 times, most recently
from
a8c773e
to
8da394a
Compare
jstejada
force-pushed
the
original-position-for
branch
from
8da394a
to
cc3ea4e
Compare
|
@bvaughn rebased on top of your changes, will land if the build passes unless you have any additional comments |
bvaughn
approved these changes
Sep 1, 2021
|
nope, doesn't seem to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit was extracted from my draft profiling commit (#22167). As part of profiling I decided to make a refactor to only call
originalPositionForonce. I don't think this actually affects performance much, since only the first call is the really expensive one, but I figured it might be worth still to consolidate extracting all the information we need from the source map into one call.Test Plan