Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched some ternary operators to more simples || operators #22208

Closed
wants to merge 1 commit into from
Closed

Switched some ternary operators to more simples || operators #22208

wants to merge 1 commit into from

Conversation

ArthurDeveloper
Copy link

No description provided.

@sizebot
Copy link

sizebot commented Aug 30, 2021

Comparing: 46a0f05...e9024af

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.60 kB 127.60 kB = 40.73 kB 40.73 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.42 kB 130.42 kB = 41.66 kB 41.66 kB
facebook-www/ReactDOM-prod.classic.js = 405.18 kB 405.18 kB = 75.05 kB 75.05 kB
facebook-www/ReactDOM-prod.modern.js = 393.75 kB 393.75 kB = 73.33 kB 73.33 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.18 kB 405.18 kB = 75.05 kB 75.05 kB
oss-experimental/react-art/Rectangle.js = 3.13 kB 3.02 kB = 1.06 kB 1.05 kB
oss-stable-semver/react-art/Rectangle.js = 3.13 kB 3.02 kB = 1.06 kB 1.05 kB
oss-stable/react-art/Rectangle.js = 3.13 kB 3.02 kB = 1.06 kB 1.05 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-art/Rectangle.js = 3.13 kB 3.02 kB = 1.06 kB 1.05 kB
oss-stable-semver/react-art/Rectangle.js = 3.13 kB 3.02 kB = 1.06 kB 1.05 kB
oss-stable/react-art/Rectangle.js = 3.13 kB 3.02 kB = 1.06 kB 1.05 kB

Generated by 🚫 dangerJS against e9024af

@gaearon
Copy link
Collaborator

gaearon commented Sep 6, 2021

This looks fine to me but generally we don't take stylistic changes unless there's some problem you're trying to fix. Thanks for the PR though.

@gaearon gaearon closed this Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants