Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build use-sync-external-store in codesandbox-ci #22352

Closed
wants to merge 2 commits into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 18, 2021

Summary

Wanted to play around with #22347 but use-sync-external-store isn't built in codesandbox-ci. For React 18 repros it isn't that big of deal since I can just use the variant exported from react. Bur for older React versions I need the shim form the package.

How did you test this change?

@sizebot
Copy link

sizebot commented Sep 18, 2021

Comparing: f50ff35...f327419

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.49 kB 129.49 kB = 41.26 kB 41.26 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 132.31 kB 132.31 kB = 42.21 kB 42.21 kB
facebook-www/ReactDOM-prod.classic.js = 410.86 kB 410.86 kB = 76.01 kB 76.01 kB
facebook-www/ReactDOM-prod.modern.js = 399.43 kB 399.43 kB = 74.29 kB 74.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 410.86 kB 410.86 kB = 76.01 kB 76.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f327419

@eps1lon eps1lon marked this pull request as ready for review September 18, 2021 12:15
@acdlite
Copy link
Collaborator

acdlite commented Sep 19, 2021

Would rather not merge this because it's slippery slope to adding all our packages to the CodeSandbox CI job. I would prefer to update the CodeSandbox config to pull the packages from CircleCI artifacts, like most of our other scripts have been updated to do.

But for your use case, what you could do instead is:

npm install https://react-builds.vercel.app/api/prs/22347/packages/use-sync-external-store

or in your package.json

"use-sync-external-store": "https://react-builds.vercel.app/api/prs/22347/packages/use-sync-external-store"

Example with CodeSandbox: https://codesandbox.io/s/billowing-dust-pmps8?file=/package.json:225-338

@eps1lon
Copy link
Collaborator Author

eps1lon commented Sep 20, 2021

Oh codesandbox didnt used to support this, thanks!

@eps1lon eps1lon closed this Sep 20, 2021
@eps1lon eps1lon deleted the chore/uSES/csb-ci branch September 20, 2021 08:02
@acdlite
Copy link
Collaborator

acdlite commented Sep 20, 2021

Oh codesandbox didnt used to support this, thanks!

I pinged them on Twitter and they fixed it haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants