Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build_devtools_and_process_artifacts to new workflow #22388

Merged
merged 1 commit into from Sep 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 6 additions & 13 deletions .circleci/config.yml
Expand Up @@ -213,9 +213,9 @@ jobs:
environment: *environment
steps:
- checkout
- attach_workspace: *attach_workspace
- attach_workspace:
at: .
- run: yarn workspaces info | head -n -1 > workspace_info.txt
- *restore_yarn_cache
- *restore_node_modules
- run:
name: Install Packages
Expand Down Expand Up @@ -344,17 +344,6 @@ jobs:
workflows:
version: 2

experimental:
unless: << pipeline.parameters.prerelease_commit_sha >>
jobs:
- setup
- yarn_build:
requires:
- setup
- build_devtools_and_process_artifacts:
requires:
- yarn_build

# New workflow that will replace "stable" and "experimental"
build_and_test:
unless: << pipeline.parameters.prerelease_commit_sha >>
Expand Down Expand Up @@ -451,6 +440,10 @@ workflows:
- RELEASE_CHANNEL_stable_yarn_test_dom_fixtures:
requires:
- yarn_build_combined
- build_devtools_and_process_artifacts:
requires:
- yarn_build_combined

fuzz_tests:
unless: << pipeline.parameters.prerelease_commit_sha >>
triggers:
Expand Down
8 changes: 7 additions & 1 deletion packages/react-devtools-core/webpack.backend.js
Expand Up @@ -18,7 +18,13 @@ if (!NODE_ENV) {
process.exit(1);
}

const builtModulesDir = resolve(__dirname, '..', '..', 'build', 'node_modules');
const builtModulesDir = resolve(
__dirname,
'..',
'..',
'build2',
'oss-experimental',
);

const __DEV__ = NODE_ENV === 'development';

Expand Down
8 changes: 7 additions & 1 deletion packages/react-devtools-core/webpack.standalone.js
Expand Up @@ -18,7 +18,13 @@ if (!NODE_ENV) {
process.exit(1);
}

const builtModulesDir = resolve(__dirname, '..', '..', 'build', 'node_modules');
const builtModulesDir = resolve(
__dirname,
'..',
'..',
'build2',
'oss-experimental',
);

const __DEV__ = NODE_ENV === 'development';

Expand Down
8 changes: 7 additions & 1 deletion packages/react-devtools-extensions/webpack.backend.js
Expand Up @@ -20,7 +20,13 @@ if (!NODE_ENV) {
process.exit(1);
}

const builtModulesDir = resolve(__dirname, '..', '..', 'build', 'node_modules');
const builtModulesDir = resolve(
__dirname,
'..',
'..',
'build2',
'oss-experimental',
);

const __DEV__ = NODE_ENV === 'development';

Expand Down
8 changes: 7 additions & 1 deletion packages/react-devtools-extensions/webpack.config.js
Expand Up @@ -20,7 +20,13 @@ if (!NODE_ENV) {
process.exit(1);
}

const builtModulesDir = resolve(__dirname, '..', '..', 'build', 'node_modules');
const builtModulesDir = resolve(
__dirname,
'..',
'..',
'build2',
'oss-experimental',
);

const __DEV__ = NODE_ENV === 'development';

Expand Down
8 changes: 7 additions & 1 deletion packages/react-devtools-shell/webpack.config.js
Expand Up @@ -24,7 +24,13 @@ if (!TARGET) {
process.exit(1);
}

const builtModulesDir = resolve(__dirname, '..', '..', 'build', 'node_modules');
const builtModulesDir = resolve(
__dirname,
'..',
'..',
'build2',
'oss-experimental',
);

const __DEV__ = NODE_ENV === 'development';

Expand Down