Duplicate of #22510 to see if CI will run #22555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent, refresh) so we do not know which referent (HostRoot, CacheComponent) created and "owns" the cache. Since any one of these could "own" the cache, retaining in passive effects could double-increment the ref count (double on top of the initial refCount=1). So instead of retaining in passive effects, we use a new cloneCache(cache) operation each time we create a new reference to the same cache. Then, passive effects change to only *releasing* cache references that are no longer reachable (due to an updated cache value at some fiber or deletinga fiber).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI isn't running on #22510 so i'm posting this to see if CI will run after adjusting circleci settings on my account