improved hashing function ------> Packages/react-refresh/src/ReactFreshBabelPlugin.js #22586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biki-das
changed the title
bvaughn
reviewed
Oct 19, 2021
| @@ -308,7 +308,7 @@ export default function(babel, opts = {}) { | |||
| // We also need it for www that has transforms like cx() | |||
| // that don't understand if something is part of a string. | |||
| finalKey = require('crypto') | |||
| .createHash('sha1') | |||
| .createHash('sha256') | |||
There was a problem hiding this comment.
I think sha256 is significantly slower than sha1. Is there a reason sha1 isn't good enough for this use case?
There was a problem hiding this comment.
Well yeah as you said "sha1" Is faster the reason i suggested it to "sha256" Is security purpose, "sha1" Has been vulnerable to browser collision attacks and overall it is less secure compared to "sha256"
There was a problem hiding this comment.
Fast Refresh is not using the hashing function in a way that has security implications.
There was a problem hiding this comment.
@bvaughn so what do you think should i close this for now?
There was a problem hiding this comment.
ok doing that , thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the 'sha1' ----> 'sha256'