Build both a partial renderer and fizz renderer of the legacy API for FB #22933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
commented
Dec 10, 2021
scripts/rollup/bundles.js
Outdated
| bundleTypes: __EXPERIMENTAL__ | ||
| ? [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD] | ||
| : [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD, FB_WWW_DEV, FB_WWW_PROD], | ||
| bundleTypes: [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD, FB_WWW_DEV, FB_WWW_PROD], |
There was a problem hiding this comment.
The classic version has an override that pulls in from partial renderer.
https://github.com/facebook/react/blob/main/packages/react-dom/src/server/ReactDOMLegacyServerBrowser.classic.fb.js
The modern version has the same config but uses the Fizz legacy implementation.
acdlite
approved these changes
Dec 10, 2021
|
Comparing: 75d34aa...47e040c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
sebmarkbage
force-pushed
the
legacyfbfizz
branch
2 times, most recently
from
8ce4cff
to
6c31274
Compare
This lets us test how the new architecture performs without comparing it to other infra changes related to streaming. I renamed the streaming one to ReactDOMServerStreaming so the references in www need to be updated. I'll open an adhoc sync with just those files.
sebmarkbage
force-pushed
the
legacyfbfizz
branch
from
6c31274
to
47e040c
Compare
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jan 10, 2022
Summary: This sync includes the following changes: - **[fe905f152](facebook/react@fe905f152 )**: Update package.json ([#22954](facebook/react#22954)) //<Jack Works>// - **[3dc41d8a2](facebook/react@3dc41d8a2 )**: fix: parseExportNamesInto specifiers typo ([#22537](facebook/react#22537)) //<btea>// - **[bd0a5dd68](facebook/react@bd0a5dd68 )**: #22988 - Fix Bug: license header in React 18 bundles contains vundefined ([#23004](facebook/react#23004)) //<Vitalie>// - **[ceee524a8](facebook/react@ceee524a8 )**: Remove unnecessary clearContainer call ([#22979](facebook/react#22979)) //<Sebastian Markbåge>// - **[cd1a3e9b5](facebook/react@cd1a3e9b5 )**: Build both a partial renderer and fizz renderer of the legacy API for FB ([#22933](facebook/react#22933)) //<Sebastian Markbåge>// Changelog: [General][Changed] - React Native sync for revisions a049aa0...fe905f1 jest_e2e[run_all_tests] Reviewed By: rickhanlonii Differential Revision: D33512179 fbshipit-source-id: c2df06c8af6bb674ea0c5524538259e6d6d98f78
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
… FB (facebook#22933) This lets us test how the new architecture performs without comparing it to other infra changes related to streaming. I renamed the streaming one to ReactDOMServerStreaming so the references in www need to be updated. I'll open an adhoc sync with just those files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us test how the new architecture performs without comparing it to other infra changes related to streaming.
I renamed the streaming one to ReactDOMServerStreaming. The references to Fizz in www need to be updated to point to this file.
I'll open an adhoc sync with just those files.