New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored DevTools test shell for e2e #22968
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf8"> | ||
| <title>React DevTools</title> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <style> | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
| body { | ||
| margin: 0; | ||
| padding: 0; | ||
| font-family: -apple-system, BlinkMacSystemFont, Segoe UI, Helvetica, Arial, | ||
| sans-serif, Apple Color Emoji, Segoe UI Emoji, Segoe UI Symbol; | ||
| font-size: 12px; | ||
| line-height: 1.5; | ||
| } | ||
| #iframe { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| width: 100vw; | ||
| height: 50vh; | ||
| } | ||
| #devtools { | ||
| position: absolute; | ||
| bottom: 0; | ||
| left: 0; | ||
| width: 100vw; | ||
| height: 50vh; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <iframe id="iframe"></iframe> | ||
| <div id="devtools"></div> | ||
| <script src="dist/e2e-devtools.js"></script> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /** @flow */ | ||
|
|
||
| // This test harness mounts each test app as a separate root to test multi-root applications. | ||
|
|
||
| import {createElement} from 'react'; | ||
| import { | ||
| // $FlowFixMe Flow does not yet know about createRoot() | ||
| createRoot, | ||
| } from 'react-dom'; | ||
| import ToDoList from '../app/ToDoList'; | ||
|
|
||
| const container = document.createElement('div'); | ||
|
|
||
| ((document.body: any): HTMLBodyElement).appendChild(container); | ||
|
|
||
| // TODO We may want to parameterize this app | ||
| // so that it can load things other than just ToDoList. | ||
|
|
||
| const root = createRoot(container); | ||
| root.render(createElement(ToDoList)); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import * as React from 'react'; | ||
| import {createRoot} from 'react-dom'; | ||
| import { | ||
| activate as activateBackend, | ||
| initialize as initializeBackend, | ||
| } from 'react-devtools-inline/backend'; | ||
| import {initialize as createDevTools} from 'react-devtools-inline/frontend'; | ||
|
|
||
| function inject(contentDocument, sourcePath, callback) { | ||
| const script = contentDocument.createElement('script'); | ||
| script.onload = callback; | ||
| script.src = sourcePath; | ||
|
|
||
| ((contentDocument.body: any): HTMLBodyElement).appendChild(script); | ||
| } | ||
|
|
||
| function init(appIframe, devtoolsContainer, appSource) { | ||
| const {contentDocument, contentWindow} = appIframe; | ||
|
|
||
| initializeBackend(contentWindow); | ||
|
|
||
| const DevTools = createDevTools(contentWindow); | ||
|
|
||
| inject(contentDocument, appSource, () => { | ||
| createRoot(devtoolsContainer).render(<DevTools />); | ||
| }); | ||
|
|
||
| activateBackend(contentWindow); | ||
| } | ||
|
|
||
| const iframe = document.getElementById('iframe'); | ||
| const devtoolsContainer = document.getElementById('devtools'); | ||
|
|
||
| init(iframe, devtoolsContainer, 'dist/e2e-app.js'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed the
app.htmlfile toindex.htmland added a small nav bar up top so we can get rid of these separate targets.