Fix:Added missing await and deleted unnecessary continue
#23023
Conversation
|
Comparing: 3dc41d8...c3c2b0c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
| @@ -216,7 +221,6 @@ async function parseExportNamesInto( | |||
| addExportNames(names, specifiers[j].exported); | |||
| } | |||
| } | |||
| continue; | |||
There was a problem hiding this comment.
here this continue does not make any sense, atleast to me , feedback needed
| @@ -193,7 +193,12 @@ async function parseExportNamesInto( | |||
| if (typeof source !== 'string') { | |||
| throw new Error('Expected the transformed source to be a string.'); | |||
| } | |||
| parseExportNamesInto(source, names, url, defaultTransformSource); | |||
| await parseExportNamesInto( | |||
There was a problem hiding this comment.
At line 173, this was a async function and await was missing, this should be added here
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
we have used an
async functionbut theawaitwas missing , alsocontinueat the end of the loop was uneccessary