Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal forks plugin to support ESM packages #23254

Closed
wants to merge 1 commit into from
Closed

Fix internal forks plugin to support ESM packages #23254

wants to merge 1 commit into from

Commits on Feb 8, 2022

  1. Fix internal forks plugin to support ESM packages 

    Our build script has a custom Rollup plugin to resolve internal module
forks. It uses require.resolve in part of its implementation. However,
require.resolve doesn't with ES Modules. So I've replaced it with a
naive userspace implementation. It doesn't need to be a general purpose
replacement, because we only use it to resolve internal modules at
build time.
    @acdlite
    acdlite committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    053559e View commit details
    Browse the repository at this point in the history