Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getSnapshot warning when a selector returns NaN #23333

Merged
merged 3 commits into from
Feb 21, 2022
Merged

fix getSnapshot warning when a selector returns NaN #23333

merged 3 commits into from
Feb 21, 2022

Commits on Feb 21, 2022

  1. fix getSnapshot warning when a selector returns NaN 

    useSyncExternalStoreWithSelector delegate a selector as
getSnapshot of useSyncExternalStore.
    @hachibeeDI
    hachibeeDI committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    d82487d View commit details
    Browse the repository at this point in the history

  2. Fiber's use sync external store has a same issue

    @hachibeeDI
    hachibeeDI committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    6a47428 View commit details
    Browse the repository at this point in the history

  3. Small nits 

    We use Object.is to check whether the snapshot value has been updated,
so we should also use it to check whether the value is cached.
    @acdlite
    acdlite committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    35a7af8 View commit details
    Browse the repository at this point in the history