Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate renderToNodeStream (and fix textarea bug) #23359

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Deprecate renderToNodeStream (and fix textarea bug) #23359

merged 4 commits into from
Feb 25, 2022

Commits on Feb 24, 2022

  1. Deprecate renderToNodeStream

    @sebmarkbage
    sebmarkbage committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    0850c4c View commit details
    Browse the repository at this point in the history

  2. Use renderToPipeableStream in tests instead of renderToNodeStream 

    This is the equivalent API. This means that we have way less test coverage
of this API but I feel like that's fine since it has a deprecation warning
in it and we have coverage on renderToString that is mostly the same.
    @sebmarkbage
    sebmarkbage committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f62de1d View commit details
    Browse the repository at this point in the history

  3. Fix textarea bug 

    The test changes revealed a bug with textarea. It happens because we
currently always insert trailing comment nodes. We should optimize that
away. However, we also don't really support complex children so we
should toString it anyway which is what partial renderer used to do.
    @sebmarkbage
    sebmarkbage committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    e915eee View commit details
    Browse the repository at this point in the history

  4. Update tests that assert number of nodes 

    These tests are unnecessarily specific about number of nodes.

I special case these, which these tests already do, because they're good
tests to test that the optimization actually works later when we do
fix it.
    @sebmarkbage
    sebmarkbage committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    509678d View commit details
    Browse the repository at this point in the history