avoid reading the scroll position twice #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #2271 (my second paragraph) |
|
cc @yungsters |
|
@sebmarkbage @spicyj cool taking this in 0.12? it's small... |
|
I think it can wait for 0.13. The fix has received no testing and this has been here since forever, so there doesn't seem to be an imminent need. |
sebmarkbage
added a commit
that referenced
this pull request
Oct 23, 2014
avoid reading the scroll position twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unnecessary scroll position read.
The scroll position is already passed to refreshScrollValues when it's called: https://github.com/facebook/react/blob/master/src/browser/ui/ReactEventListener.js#L89-L92