-
Notifications
You must be signed in to change notification settings - Fork 45.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests for suppressHydrationWarning #24275
Conversation
return ( | ||
<div> | ||
<span suppressHydrationWarning={true}> | ||
{isClient ? null : 'Server'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, {isClient ? null : 'Server'}
throws. But {isClient ? 'Client' : null}
works fine. {isClient ? 'Client' : 'Server'}
also works fine. Should we make it consistent?
Comparing: fc47cb1...ac628a3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
it's just a test |
* More tests for suppressHydrationWarning * Move suppressHydration tests to new file * Extract more tests * Test name * Test legacy behavior too
* More tests for suppressHydrationWarning * Move suppressHydration tests to new file * Extract more tests * Test name * Test legacy behavior too
* More tests for suppressHydrationWarning * Move suppressHydration tests to new file * Extract more tests * Test name * Test legacy behavior too
Copy paste into another file and add a few more cases to document the current behavior.