[DevTools] Rename react-dom/testing to react-dom/unstable_testing in yarn build-for-devtools #24364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: f7cf077...4f4db3f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
|
@bvaughn Has the |
acdlite
approved these changes
Apr 13, 2022
bvaughn
approved these changes
Apr 13, 2022
|
Ah I see. It's cause react-dom/test was renamed to react-dom/unstable_test |
lunaruan
force-pushed
the
devtools_package_json
branch
from
db804f8
to
86402dd
Compare
lunaruan
force-pushed
the
devtools_package_json
branch
from
86402dd
to
4f4db3f
Compare
lunaruan
changed the title
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 14, 2022
…for-devtools (#24364) The shell package wasn't compiling because yarn build-for-devtools was incorrect. The react-dom/test package was renamed to react-dom/unstable_testing. This PR fixes this in the package.json. Note: Adding packages to the yarn build-for-devtools command isn't great in the long run. Eventually we should make devtools have its own build script.
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
…for-devtools (facebook#24364) The shell package wasn't compiling because yarn build-for-devtools was incorrect. The react-dom/test package was renamed to react-dom/unstable_testing. This PR fixes this in the package.json. Note: Adding packages to the yarn build-for-devtools command isn't great in the long run. Eventually we should make devtools have its own build script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell package wasn't compiling because
yarn build-for-devtoolswas incorrect. Thereact-dom/testpackage was renamed toreact-dom/unstable_testing. This PR fixes this in thepackage.json.Note: Adding packages to the
yarn build-for-devtoolscommand isn't great in the long run. Eventually we should make devtools have its own build script.