Constrain the container type of createPortal #24496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already constrained the type of createRoot (can't take document) and hydrateRoot (can't take fragments).
sebmarkbage
commented
May 5, 2022
| @@ -107,7 +107,7 @@ setBatchingImplementation( | |||
|
|
|||
| function createPortal( | |||
| children: ReactNodeList, | |||
| container: Container, | |||
| container: Element | DocumentFragment, | |||
| key: ?string = null, | |||
| ): React$Portal { | |||
| if (!isValidContainer(container)) { | |||
There was a problem hiding this comment.
We have this helper function but I think it doesn't make sense. We should test these independently since they're not all the same. This one should error on document for example.
However, should we also make it a DEV only warning so we don't need the code?
|
Comparing: 0dc4e66...544a1b2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
approved these changes
May 5, 2022
gnoff
approved these changes
May 5, 2022
|
@eps1lon I noticed that the TypeScript one is limited to Element but I think we technically support shadow roots too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already constrained the type of createRoot (can't take document) and hydrateRoot (can't take shadow roots aka fragments).