[DevTools] Add Snapshots on e2e test failure #24672
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
| }, | ||
| // Some of our e2e tests can be flaky. Retry tests to make sure the error isn't transient | ||
| retries: 2, |
There was a problem hiding this comment.
Does this mean it wasn't retrying before?
There was a problem hiding this comment.
We were, just twice instead of 3 times
There was a problem hiding this comment.
I think flaky tests might actually be categorized as an error though, so looking into that as well. Figured we probably want snapshots of failing tests regardless though
There was a problem hiding this comment.
small nit: was the move of the comment intended?
|
Comparing: 7a5b822...f1e41df Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
.circleci/config.yml
Outdated
| @@ -270,6 +270,8 @@ jobs: | |||
| - run: | |||
| name: Cleanup build regression folder | |||
| command: rm -r ./build-regression | |||
| - store_artifacts: | |||
| path: tmp/screenshots | |||
There was a problem hiding this comment.
Is this configured somewhere? I think the default output directory of playwright trace report is called "test-results"
There was a problem hiding this comment.
Oooh good call I didn't push my most recent commit to main thanks!!
We have a currently unreproducible flaky e2e test. This PR captures snapshots on e2e test failures so we can better debug flaky e2e tests that don't fail locally.