Make hard JS indexof not found error more developer-friendly #24744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dexOf'. Throw a more specific error with a clue about what parentInstance.child actually was when it was called incorrectly. Add the check to removeChild, since that gets called with the same invalid parentInstance even though addChild threw and never completed.
|
Comparing: 56389e8...7ba1e65 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
bump |
github-actions
bot
removed
the
Resolution: Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While debugging some new console output in the debugger complaining about a call attempt on a non-function, I found this test's
toThrow()was meant to capture the hard JS error, but wasn't specific. To make the toThrow() more specific, and provide more helpful information in the error, I crafted a more developer-friendly message to include in the thrown Error that should save a debugging cycle for the next people that run into it. I noticed that I had to add the check in removeChild as well, which attempted to callindexOfon the same invalidparentInstance.childrenwithout checking the type.How did you test this change?
I augmented the existing test to verify the specific user-friendly thrown error, and added a second test case that captures the original abuse case whose debugging led me to discover this issue.
yarn testandyarn test --prodboth pass on my x64 MacBook Pro running MacOS 12.4 and the node version specified in the repo's .nvmrc file.