[Fizz/Float] Implement preloading in Fizz #24750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Jun 18, 2022
gaearon
reviewed
Jun 18, 2022
You can now render a head anywhere in the stream and it will be inserted before the body Resources now flush inside the head or before body content onPreload is supported for preloads that occur before the stream has started flushing
gaearon
reviewed
Jun 24, 2022
The prior commits added support for rendering <head> anywhere in the shell. This commit adds the ability to pass a defaultHead to Fizz which will be used if no <head> is discovered when rendering the shell. To ensure we did not eagerly render the defaultHead there is a test task priorty called lazyTasks which are worked on only when there are no other outstanding tasks. This ensures that if a <head> will be discovered in the shell the lazyTask can be aborted before is renderes into the headSegment. It is worth pointing out that the headSegment and headBoundary are using some of the mechanics of suspense boundaries but they do not want to follow suspense semantics. namely if we render the defaultHead which is kind of like a fallback we don't want to emit a placeholder template. The reason is <heads> will be treated different from other kinds of HostElements on the client where you can render 1 and a time and they hoist into head position. They are a sort of portal to the document head and so hydration semantics won't apply the same way nor will there be a need for fallback behaviors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress...
Using PR to generate builds. will follow up with a proper description when the implementation is more completed