Add more test cases for exhaustive deps check #25108
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
There seems to be a discrepancy in
eslint-plugin-react-hooks
when testing exhaustive deps. The following code reports an error:While the below code does not:
I think that this might be a valid edge case which users might run into. Hence, I have added a few test cases as well as extended the eslint plugin logic to catch and report this scenario.