Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: atrribute -> attribute #25428

Closed
wants to merge 1 commit into from
Closed

Fix typo: atrribute -> attribute #25428

wants to merge 1 commit into from

Conversation

zhangrenyang
Copy link
Contributor

Summary

How did you test this change?

@sizebot
Copy link

sizebot commented Oct 5, 2022

Comparing: 2872a26...65a8119

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 135.46 kB 135.46 kB = 43.44 kB 43.44 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 147.96 kB 147.96 kB = 47.32 kB 47.32 kB
facebook-www/ReactDOM-prod.classic.js = 491.72 kB 491.72 kB = 87.50 kB 87.50 kB
facebook-www/ReactDOM-prod.modern.js = 477.00 kB 477.00 kB = 85.27 kB 85.27 kB
facebook-www/ReactDOMForked-prod.classic.js = 491.72 kB 491.72 kB = 87.50 kB 87.50 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 65a8119

@gaearon
Copy link
Collaborator

gaearon commented Oct 5, 2022

thanks, but we have a policy of not taking non-user-facing typo fixes because we want to keep the commit history more focused.

@gaearon gaearon closed this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants