Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Reuse variable "remoteRepoDir" #25740

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Refactor: Reuse variable "remoteRepoDir" #25740

merged 1 commit into from
Jan 10, 2023

Conversation

HoikanChan
Copy link
Contributor

Reuse variable remoteRepoDir , same with join(__dirname, 'remote-repo').

@facebook-github-bot
Copy link

Hi @HoikanChan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@sizebot
Copy link

sizebot commented Nov 25, 2022

Comparing: 2655c93...f40438b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.33 kB 154.33 kB = 48.98 kB 48.98 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.25 kB 156.25 kB = 49.60 kB 49.60 kB
facebook-www/ReactDOM-prod.classic.js = 533.14 kB 533.14 kB = 94.42 kB 94.42 kB
facebook-www/ReactDOM-prod.modern.js = 518.24 kB 518.24 kB = 92.24 kB 92.24 kB
facebook-www/ReactDOMForked-prod.classic.js = 533.14 kB 533.14 kB = 94.42 kB 94.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f40438b

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@HoikanChan HoikanChan marked this pull request as draft November 28, 2022 08:58
@HoikanChan HoikanChan marked this pull request as ready for review November 28, 2022 08:58
@kassens kassens merged commit 1253462 into facebook:main Jan 10, 2023
github-actions bot pushed a commit that referenced this pull request Jan 10, 2023
@kassens
Refactor: Reuse variable "remoteRepoDir" (#25740)
6283e19 
Reuse variable `remoteRepoDir` , same with `join(__dirname, 'remote-repo')`.

DiffTrain build for [1253462](1253462)
[View git log for this commit](https://github.com/facebook/react/commits/1253462ea48db362faad864695a172f5a56759ca)
@sammy-SC sammy-SC mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HoikanChan @facebook-github-bot @sizebot @kassens