Remove unused dependency 'abort-controller' #26074
Conversation
|
Comparing: d7bb524...a299e26 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
ymqy
changed the title
ymqy
changed the title
ymqy
changed the title
ymqy
changed the title
| @@ -36,7 +36,6 @@ | |||
| "@babel/preset-flow": "^7.10.4", | |||
| "@babel/preset-react": "^7.10.4", | |||
| "@babel/traverse": "^7.11.0", | |||
| "abort-controller": "^3.0.0", | |||
There was a problem hiding this comment.
Added in #21027 but it doesn't look like it was even used in that PR. Maybe something used during development?
There was a problem hiding this comment.
There was a problem hiding this comment.
Hm. Interestingly that fix is only on the client. It didn’t necessarily fix the server. I guess we just don’t run tests in earlier node environments and we don’t really support them anyway.
There was a problem hiding this comment.
It should be safe to remove this dependency
There was a problem hiding this comment.
Given that nothing requires this dependency at the moment, it seems like we can remove it at least until we do require it again. Seems like that might be required for some old node versions, but it seems like they'd need to be tested more extensively anyway.
If someone want's to use abort-controller again, it'd easy to add back the dependency. I'll merge this.
## Summary This PR removes the unused dependency 'abort-controller' from the project. it helps to keep the project clean and maintainable. ## How did you test this change? ci green DiffTrain build for [8b9ac81](8b9ac81) [View git log for this commit](https://github.com/facebook/react/commits/8b9ac8175fb3052ba5c82f99003bb8ff667e1e68)
Summary
This PR removes the unused dependency 'abort-controller' from the project. it helps to keep the project clean and maintainable.
How did you test this change?
ci green