Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental][Fizz Server] Non-executable bootstrapScript content format #26163

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Feb 14, 2023

[donotcommit] Draft PR, implementation does not properly escape invalid inputs or consider all cases

Experiment with non-executable format for bootstrap scripts, in the form of <script type="..."> data </script>.

Summary

How did you test this change?

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 14, 2023
@mofeiZ mofeiZ changed the title [experimental][Fizz] Non-executable bootstrapScript content format [experimental][Fizz Server] Non-executable bootstrapScript content format Feb 14, 2023
@react-sizebot
Copy link

Comparing: fccf3a9...78a9bec

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 154.54 kB 154.54 kB = 48.83 kB 48.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 156.54 kB 156.54 kB = 49.45 kB 49.45 kB
facebook-www/ReactDOM-prod.classic.js = 529.73 kB 529.73 kB = 94.36 kB 94.36 kB
facebook-www/ReactDOM-prod.modern.js = 514.95 kB 514.95 kB = 92.17 kB 92.17 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.min.js +0.42% 52.85 kB 53.08 kB +0.64% 16.51 kB 16.61 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.min.js +0.42% 52.88 kB 53.10 kB +0.64% 16.53 kB 16.63 kB
oss-experimental/react-dom/umd/react-dom-server.browser.production.min.js +0.42% 53.27 kB 53.49 kB +0.67% 16.84 kB 16.95 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.production.min.js +0.42% 53.09 kB 53.31 kB +0.62% 16.61 kB 16.71 kB
oss-experimental/react-dom/cjs/react-dom-static.edge.production.min.js +0.42% 53.15 kB 53.37 kB +0.62% 16.63 kB 16.73 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.min.js +0.42% 53.21 kB 53.43 kB +0.63% 16.65 kB 16.76 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.production.min.js +0.42% 52.91 kB 53.13 kB +0.69% 16.70 kB 16.81 kB
oss-stable/react-dom/umd/react-dom-server.browser.production.min.js +0.42% 52.93 kB 53.15 kB +0.69% 16.72 kB 16.83 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.min.js +0.39% 56.60 kB 56.82 kB +0.53% 17.76 kB 17.86 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.min.js +0.39% 56.62 kB 56.85 kB +0.54% 17.78 kB 17.88 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.min.js +0.39% 57.02 kB 57.25 kB +0.53% 17.93 kB 18.02 kB
oss-experimental/react-dom/cjs/react-dom-static.node.production.min.js +0.34% 57.40 kB 57.59 kB +0.41% 18.04 kB 18.11 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.min.js +0.33% 56.97 kB 57.16 kB +0.40% 17.87 kB 17.94 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.min.js +0.33% 57.00 kB 57.18 kB +0.40% 17.89 kB 17.96 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.min.js +0.33% 57.40 kB 57.59 kB +0.42% 18.04 kB 18.11 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.min.js +0.30% 55.45 kB 55.62 kB +0.32% 17.07 kB 17.12 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.min.js +0.30% 55.48 kB 55.64 kB +0.31% 17.09 kB 17.14 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.min.js +0.30% 55.88 kB 56.04 kB +0.31% 17.23 kB 17.28 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.25% 353.00 kB 353.87 kB +0.24% 77.73 kB 77.91 kB
facebook-www/ReactDOMServer-dev.modern.js +0.24% 357.90 kB 358.77 kB +0.24% 78.96 kB 79.14 kB
facebook-www/ReactDOMServer-dev.classic.js +0.24% 364.57 kB 365.44 kB +0.23% 80.11 kB 80.30 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.23% 129.53 kB 129.83 kB +0.29% 24.77 kB 24.84 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js +0.23% 334.06 kB 334.83 kB +0.20% 75.96 kB 76.11 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js +0.23% 334.08 kB 334.86 kB +0.20% 75.98 kB 76.13 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js +0.23% 335.41 kB 336.19 kB +0.20% 76.34 kB 76.50 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.23% 336.92 kB 337.69 kB +0.20% 76.52 kB 76.67 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.23% 336.94 kB 337.72 kB +0.20% 76.54 kB 76.69 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.23% 337.08 kB 337.86 kB +0.19% 76.74 kB 76.89 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.23% 337.11 kB 337.88 kB +0.19% 76.76 kB 76.91 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js +0.23% 337.23 kB 338.00 kB +0.19% 76.79 kB 76.93 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js +0.23% 337.25 kB 338.03 kB +0.19% 76.80 kB 76.95 kB
oss-experimental/react-dom/cjs/react-dom-static.browser.development.js +0.23% 337.74 kB 338.52 kB +0.20% 76.94 kB 77.09 kB
oss-experimental/react-dom/cjs/react-dom-static.edge.development.js +0.23% 337.89 kB 338.66 kB +0.20% 76.98 kB 77.13 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +0.23% 338.27 kB 339.05 kB +0.20% 76.90 kB 77.06 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.23% 338.44 kB 339.21 kB +0.20% 77.13 kB 77.28 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.23% 338.51 kB 339.29 kB +0.20% 76.76 kB 76.92 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.23% 338.53 kB 339.31 kB +0.20% 76.79 kB 76.94 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js +0.23% 338.58 kB 339.36 kB +0.20% 77.17 kB 77.32 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js +0.23% 338.76 kB 339.54 kB +0.20% 77.01 kB 77.17 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js +0.23% 338.79 kB 339.56 kB +0.20% 77.03 kB 77.19 kB
oss-experimental/react-dom/cjs/react-dom-static.node.development.js +0.23% 339.82 kB 340.60 kB +0.19% 77.24 kB 77.39 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.23% 339.86 kB 340.64 kB +0.20% 77.15 kB 77.30 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +0.23% 340.12 kB 340.89 kB +0.20% 77.40 kB 77.55 kB
oss-stable-semver/react-dom/umd/react-dom-server-legacy.browser.development.js +0.23% 352.73 kB 353.53 kB +0.20% 77.34 kB 77.49 kB
oss-stable/react-dom/umd/react-dom-server-legacy.browser.development.js +0.23% 352.75 kB 353.55 kB +0.20% 77.36 kB 77.51 kB
oss-stable-semver/react-dom/umd/react-dom-server.browser.development.js +0.23% 352.89 kB 353.69 kB +0.21% 77.57 kB 77.73 kB
oss-stable/react-dom/umd/react-dom-server.browser.development.js +0.23% 352.92 kB 353.72 kB +0.21% 77.59 kB 77.75 kB
oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js +0.23% 354.16 kB 354.96 kB +0.20% 77.73 kB 77.88 kB
oss-experimental/react-dom/umd/react-dom-server.browser.development.js +0.23% 354.33 kB 355.13 kB +0.21% 77.95 kB 78.12 kB

Generated by 🚫 dangerJS against 78a9bec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants