fix: sourceMaps option is invalid #26216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In facebook#24577, the `--sourceMaps` option was added, but modifying the `--sourceMaps` option has no effect. Because `process.env.JEST_ENABLE_SOURCE_MAPS` was not added to the string array of `createCacheKeyFunction`, it caused a cache to be generated when the first test was run, and when the second test was run, modifying `process.env.JEST_ENABLE_SOURCE_MAPS` would not affect the running result, resulting in the failure of the `--sourceMaps`.
|
Comparing: ca2cf31...9a2591c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24577, the
--sourceMapsoption was added, but modifying the--sourceMapsoption has no effect.Because
--sourceMapsworks by adding the environment variableJEST_ENABLE_SOURCE_MAPS, but does not addprocess.env.JEST_ENABLE_SOURCE_MAPSto the array of strings thatcreateCacheKeyFunctionneeds to consider when generating cache keys, it caused a cache to be generated when the first test was run, and when the second test was run, modifyingprocess.env.JEST_ENABLE_SOURCE_MAPSwould not affect the running result, resulting in the failure of the--sourceMaps.