Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SyntheticKeyboardEvent isComposing #26254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhbs
Copy link

@bhbs bhbs commented Feb 27, 2023

Summary

Fixes #13104

Just added isComposing
If we don't have to consider IE, then we don't need a polyfill for this property.

https://caniuse.com/mdn-api_keyboardevent_iscomposing

How did you test this change?

No automated tests found

@facebook-github-bot
Copy link

Hi @bhbs!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@bhbs bhbs force-pushed the add-support-for-keyboard-event-iscomposing branch 2 times, most recently from f77c3fd to 65b326a Compare February 28, 2023 02:52
@react-sizebot
Copy link

react-sizebot commented Feb 28, 2023

Comparing: 90172d1...60077ce

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 174.94 kB 174.95 kB +0.01% 54.44 kB 54.45 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.06 kB 177.08 kB +0.01% 55.12 kB 55.13 kB
facebook-www/ReactDOM-prod.classic.js = 567.28 kB 567.30 kB = 99.85 kB 99.85 kB
facebook-www/ReactDOM-prod.modern.js = 551.14 kB 551.16 kB = 96.94 kB 96.94 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 60077ce

@bhbs bhbs force-pushed the add-support-for-keyboard-event-iscomposing branch from 65b326a to 60077ce Compare October 21, 2023 08:17
Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 9, 2024
@bhbs
Copy link
Author

bhbs commented Apr 10, 2024

bump

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for SyntheticKeyboardEvent#isComposing
3 participants