Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rm server error base64 entry from /error-codes/codes.json map #26438

Closed
wants to merge 5 commits into from
Closed

chore: rm server error base64 entry from /error-codes/codes.json map #26438

wants to merge 5 commits into from

Conversation

Pranav-yadav
Copy link

@Pranav-yadav Pranav-yadav commented Mar 20, 2023 •
edited

Summary

  • rm server error base64 entry from /error-codes/codes.json map
  • this error only occurs in a server build, where we don't replace error messages with codes.

-- w/ 馃惣

@Pranav-yadav
Fix: typo expect :)
4e6ffb3 
`codes.json` Line: 461

```diff
- except
+ expect
````

w/ 馃惣
@react-sizebot
Copy link

react-sizebot commented Mar 20, 2023 •
edited

Comparing: 9c54b29...baaf29b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 159.33 kB 159.33 kB = 50.47 kB 50.47 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 161.07 kB 161.07 kB = 50.98 kB 50.98 kB
facebook-www/ReactDOM-prod.classic.js = 546.16 kB 546.16 kB = 96.84 kB 96.84 kB
facebook-www/ReactDOM-prod.modern.js = 529.86 kB 529.86 kB = 94.38 kB 94.38 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 馃毇 dangerJS against baaf29b

@acdlite
Copy link
Collaborator

acdlite commented Mar 20, 2023

I was surprised that CI didn't catch this, because it's supposed to error if there's no matching message in that file. But then I realized this error only occurs in a server build, where we don't replace error messages with codes.

So I think what you should do instead is delete this message from the map.

@Pranav-yadav
Copy link
Author

Pranav-yadav commented Mar 21, 2023 •
edited

Exactly, I was also surprised by; why CI didn't fail at first place (catch it earlier).

Thanks for investigating.
Pushing...

Thanks :)

PS: will you take a quick look at this PR #26424 comment #26424 (comment)
I just want opinion from one more team member; there, before proceeding.

@Pranav-yadav Pranav-yadav changed the title Fix: typo except -> expect in codes.json :) chore: rm server error base64 entry from /error-codes/codes.json map Mar 21, 2023
@eps1lon eps1lon requested a review from acdlite March 22, 2023 09:32
@Pranav-yadav
Copy link
Author

ping @acdlite
just in case you missed the review req. ;)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 9, 2024
@github-actions GitHub Actions
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pranav-yadav @react-sizebot @acdlite @facebook-github-bot