Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zoom from special cases list #26631

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

sebmarkbage
Copy link
Collaborator

Looks like it's getting removed anyway.

Maybe should wait for a major though.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 15, 2023
@react-sizebot
Copy link

Comparing: 7b0642b...0664786

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.35 kB 164.34 kB = 51.65 kB 51.64 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 166.79 kB 166.78 kB = 52.31 kB 52.31 kB
facebook-www/ReactDOM-prod.classic.js = 564.28 kB 564.27 kB = 99.34 kB 99.33 kB
facebook-www/ReactDOM-prod.modern.js = 548.07 kB 548.06 kB = 96.64 kB 96.64 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0664786

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait for a major probably

@sebmarkbage sebmarkbage merged commit f24cf4a into facebook:main Mar 26, 2024
@sophiebits
Copy link
Collaborator

@sebmarkbage wait this has since been standardized. So I think we should keep it?

github-actions bot pushed a commit that referenced this pull request Mar 26, 2024
Looks like [it's getting removed
anyway](https://groups.google.com/a/chromium.org/g/blink-dev/c/V7q43bgutbo/m/-7jneTl8CQAJ?pli=1).

Maybe should wait for a major though.

DiffTrain build for [f24cf4a](f24cf4a)
sophiebits added a commit that referenced this pull request Mar 29, 2024
sophiebits added a commit that referenced this pull request Mar 29, 2024
Reverts #26631

This got specced: w3c/csswg-drafts#9699

I left msZoom because it seems plausible someone will still be using it
for backwards compat.
github-actions bot pushed a commit that referenced this pull request Mar 29, 2024
Reverts #26631

This got specced: w3c/csswg-drafts#9699

I left msZoom because it seems plausible someone will still be using it
for backwards compat.

DiffTrain build for [19c7c29](19c7c29)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Reverts facebook#26631

This got specced: w3c/csswg-drafts#9699

I left msZoom because it seems plausible someone will still be using it
for backwards compat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants