Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse request so that a ReadableStream body does not become disturbed #26771

Merged
merged 5 commits into from May 3, 2023
Merged

Reuse request so that a ReadableStream body does not become disturbed #26771

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee88953
clone request
agadzik May 3, 2023
813c1df
handle the case where resource is still a string
agadzik May 3, 2023
bb33b74
reuse the resource as a Request instead of cloning
agadzik May 3, 2023
095ad3a
Handle the case where resource could be a URL
agadzik May 3, 2023
70cf10a
fix prettier error
agadzik May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react/src/ReactFetch.js
View file
Open in desktop
Expand Up @@ -74,7 +74,8 @@ if (enableCache && enableFetchInstrumentation) {
url = resource;
} else {
// Normalize the request.
const request = new Request(resource, options);
// we clone the request as to not disturb the body (in the event it's a ReadableStream)
const request = resource.clone();
agadzik marked this conversation as resolved.
Show resolved Hide resolved
if (
(request.method !== 'GET' && request.method !== 'HEAD') ||
// $FlowFixMe[prop-missing]: keepalive is real
Expand Down