Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly job to publish to "canary" channel #26799

Merged
merged 1 commit into from May 10, 2023

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented May 10, 2023

When I was renaming the next channel to canary, I updated the publish_preleases workflow correctly, but I skipped over publish_preleases_nightly. Oops.

When I was renaming the next channel to canary, I updated the
`publish_preleases` wokflow correctly, but I skipped over
`publish_preleases_nightly`. Oops.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 10, 2023
@react-sizebot
Copy link

Comparing: b581016...9d0d7c1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.19 kB 164.19 kB = 51.78 kB 51.78 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.55 kB 171.55 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 570.13 kB 570.13 kB = 100.62 kB 100.62 kB
facebook-www/ReactDOM-prod.modern.js = 553.87 kB 553.87 kB = 97.80 kB 97.80 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 9d0d7c1

@acdlite acdlite merged commit 7cd98ef into facebook:main May 10, 2023
36 checks passed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
When I was renaming the next channel to canary, I updated the
`publish_preleases` workflow correctly, but I skipped over
`publish_preleases_nightly`. Oops.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
When I was renaming the next channel to canary, I updated the
`publish_preleases` workflow correctly, but I skipped over
`publish_preleases_nightly`. Oops.

DiffTrain build for commit 7cd98ef.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants