Fix strict mode badge URL #26825
Merged
Fix strict mode badge URL #26825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the URL in the strict mode badge to point to the correct React documentation for StrictMode. The previous URL was outdated. Now, when a component is not running in StrictMode, the badge will link to https://react.dev/reference/react/StrictMode for more information.
hoxyq
added a commit
that referenced
this pull request
Jul 4, 2023
List of changes: * Devtools:-Removed unused CSS ([Biki-das](https://github.com/Biki-das) in [#27032](#27032)) * fix[devtools/profilingCache-test]: specify correct version gate for test ([hoxyq](https://github.com/hoxyq) in [#27008](#27008)) * fix[devtools/ci]: fixed incorrect condition calculation for @reactVersion annotation ([hoxyq](https://github.com/hoxyq) in [#26997](#26997)) * fix[ci]: fixed jest configuration not to skip too many devtools tests ([hoxyq](https://github.com/hoxyq) in [#26955](#26955)) * fix[devtools/standalone]: update webpack configurations ([hoxyq](https://github.com/hoxyq) in [#26963](#26963)) * fix[devtools]: check if fiber is unmounted before trying to highlight ([hoxyq](https://github.com/hoxyq) in [#26983](#26983)) * feat[devtools]: support x_google_ignoreList source maps extension ([hoxyq](https://github.com/hoxyq) in [#26951](#26951)) * chore[devtools]: upgrade to webpack v5 ([hoxyq](https://github.com/hoxyq) in [#26887](#26887)) * fix[devtools]: display NaN as string in values ([hoxyq](https://github.com/hoxyq) in [#26947](#26947)) * fix: devtools cannot be closed correctly ([Jack-Works](https://github.com/Jack-Works) in [#25510](#25510)) * Fix:- Fixed dev tools inspect mode on Shadow dom ([Biki-das](https://github.com/Biki-das) in [#26888](#26888)) * Updated copyright text to Copyright (c) Meta Platforms, Inc. and its … ([denmo530](https://github.com/denmo530) in [#26830](#26830)) * Fix strict mode badge URL ([ibrahemid](https://github.com/ibrahemid) in [#26825](#26825))
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
## Summary Closes facebook#26821 [[Fix facebook#26821]](facebook#26821) Update strict mode badge URL Updated the URL in the strict mode badge to point to the correct React documentation for StrictMode. The previous URL was outdated. Now, when a component is not running in StrictMode, the badge links to https://react.dev/reference/react/StrictMode for more information. ## How did you test this change? I verified that the strict mode badge now correctly links to the updated URL. Previously, it pointed to the outdated URL (https://fb.me/devtools-strict-mode). After the update, it correctly points to the React Dev documentation for StrictMode (https://react.dev/reference/react/StrictMode). _Since its my first contribution here, i have completed the CLA_
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
List of changes: * Devtools:-Removed unused CSS ([Biki-das](https://github.com/Biki-das) in [facebook#27032](facebook#27032)) * fix[devtools/profilingCache-test]: specify correct version gate for test ([hoxyq](https://github.com/hoxyq) in [facebook#27008](facebook#27008)) * fix[devtools/ci]: fixed incorrect condition calculation for @reactVersion annotation ([hoxyq](https://github.com/hoxyq) in [facebook#26997](facebook#26997)) * fix[ci]: fixed jest configuration not to skip too many devtools tests ([hoxyq](https://github.com/hoxyq) in [facebook#26955](facebook#26955)) * fix[devtools/standalone]: update webpack configurations ([hoxyq](https://github.com/hoxyq) in [facebook#26963](facebook#26963)) * fix[devtools]: check if fiber is unmounted before trying to highlight ([hoxyq](https://github.com/hoxyq) in [facebook#26983](facebook#26983)) * feat[devtools]: support x_google_ignoreList source maps extension ([hoxyq](https://github.com/hoxyq) in [facebook#26951](facebook#26951)) * chore[devtools]: upgrade to webpack v5 ([hoxyq](https://github.com/hoxyq) in [facebook#26887](facebook#26887)) * fix[devtools]: display NaN as string in values ([hoxyq](https://github.com/hoxyq) in [facebook#26947](facebook#26947)) * fix: devtools cannot be closed correctly ([Jack-Works](https://github.com/Jack-Works) in [facebook#25510](facebook#25510)) * Fix:- Fixed dev tools inspect mode on Shadow dom ([Biki-das](https://github.com/Biki-das) in [facebook#26888](facebook#26888)) * Updated copyright text to Copyright (c) Meta Platforms, Inc. and its … ([denmo530](https://github.com/denmo530) in [facebook#26830](facebook#26830)) * Fix strict mode badge URL ([ibrahemid](https://github.com/ibrahemid) in [facebook#26825](facebook#26825))
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
## Summary Closes #26821 [[Fix #26821]](#26821) Update strict mode badge URL Updated the URL in the strict mode badge to point to the correct React documentation for StrictMode. The previous URL was outdated. Now, when a component is not running in StrictMode, the badge links to https://react.dev/reference/react/StrictMode for more information. ## How did you test this change? I verified that the strict mode badge now correctly links to the updated URL. Previously, it pointed to the outdated URL (https://fb.me/devtools-strict-mode). After the update, it correctly points to the React Dev documentation for StrictMode (https://react.dev/reference/react/StrictMode). _Since its my first contribution here, i have completed the CLA_ DiffTrain build for commit d7a98a5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #26821
[Fix #26821] Update strict mode badge URL
Updated the URL in the strict mode badge to point to the correct React documentation for StrictMode. The previous URL was outdated. Now, when a component is not running in StrictMode, the badge links to https://react.dev/reference/react/StrictMode for more information.
How did you test this change?
I verified that the strict mode badge now correctly links to the updated URL. Previously, it pointed to the outdated URL (https://fb.me/devtools-strict-mode). After the update, it correctly points to the React Dev documentation for StrictMode (https://react.dev/reference/react/StrictMode).
Since its my first contribution here, i have completed the CLA