Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update enableSyncDefaultUpdates for www #26857

Merged
merged 1 commit into from May 26, 2023
Merged

Update enableSyncDefaultUpdates for www #26857

merged 1 commit into from May 26, 2023

Conversation

rickhanlonii
Copy link
Member

If this is false, it dead code eliminates the path to use the root flag. Will follow up to clean this up.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 26, 2023
@react-sizebot
Copy link

Comparing: 4daccad...de4df88

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.23 kB 164.23 kB = 51.77 kB 51.77 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.59 kB 171.59 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js +0.04% 570.22 kB 570.42 kB = 100.63 kB 100.64 kB
facebook-www/ReactDOM-prod.modern.js +0.04% 553.95 kB 554.16 kB = 97.81 kB 97.82 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against de4df88

@rickhanlonii rickhanlonii merged commit 0210f0b into main May 26, 2023
34 of 36 checks passed
@rickhanlonii rickhanlonii deleted the rh/fix-trunk branch May 26, 2023 01:33
github-actions bot pushed a commit that referenced this pull request May 26, 2023
@rickhanlonii
Update enableSyncDefaultUpdates for www (#26857)
abcb33d 
If this is false, it dead code eliminates the path to use the root flag.
Will follow up to clean this up.

DiffTrain build for [0210f0b](0210f0b)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@rickhanlonii @AndyPengc12
Update enableSyncDefaultUpdates for www (facebook#26857)
fd1c0b2 
If this is false, it dead code eliminates the path to use the root flag.
Will follow up to clean this up.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@rickhanlonii
Update enableSyncDefaultUpdates for www (#26857)
f3bd734 
If this is false, it dead code eliminates the path to use the root flag.
Will follow up to clean this up.

DiffTrain build for commit 0210f0b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyao1 tyao1 tyao1 approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rickhanlonii @react-sizebot @tyao1 @facebook-github-bot