Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate babel dependencies as they already installed in the repo root #27054

Conversation

anatoliik-lyft
Copy link
Contributor

@anatoliik-lyft anatoliik-lyft commented Jul 5, 2023

Summary

This PR cleans up the monorepo dependencies by removing duplicate Babel dependencies that are already installed in the repo root

How did you test this change?

  • Ran yarn test --prod
  • Ran yarn test

@facebook-github-bot
Copy link

Hi @anatoliik-lyft!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-sizebot
Copy link

react-sizebot commented Jul 5, 2023

Comparing: 035a41c...c1b375b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 164.35 kB 164.35 kB = 51.76 kB 51.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 171.76 kB 171.76 kB = 53.98 kB 53.98 kB
facebook-www/ReactDOM-prod.classic.js = 567.22 kB 567.22 kB = 100.04 kB 100.04 kB
facebook-www/ReactDOM-prod.modern.js = 551.02 kB 551.02 kB = 97.21 kB 97.21 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against c1b375b

@anatoliik-lyft anatoliik-lyft force-pushed the anatoliik/remove-duplicate-babel-deps branch 2 times, most recently from 6cda013 to e1e4f0c Compare July 5, 2023 07:02
@anatoliik-lyft anatoliik-lyft force-pushed the anatoliik/remove-duplicate-babel-deps branch from 9c119c8 to c1b375b Compare July 7, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants